Skip to content

Comments

[PW_SID:1055816] riscv: dts: sifive: fu740: Fix compatible strings per IP versioning#1481

Open
linux-riscv-bot wants to merge 5 commits intoworkflow__riscv__fixesfrom
pw1055816
Open

[PW_SID:1055816] riscv: dts: sifive: fu740: Fix compatible strings per IP versioning#1481
linux-riscv-bot wants to merge 5 commits intoworkflow__riscv__fixesfrom
pw1055816

Conversation

@linux-riscv-bot
Copy link

PR for series 1055816 applied to workflow__riscv__fixes

Name: riscv: dts: sifive: fu740: Fix compatible strings per IP versioning
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=1055816
Version: 1

Add the SiFive FU740-C000 ethernet controller compatible string to the
Cadence MACB binding documentation.

The FU740 ethernet controller uses the same GEMGXL management block as
the FU540, which is tightly coupled with the Cadence MACB IP. This
follows the SiFive IP versioning scheme which requires SoC-specific
compatible strings for proper hardware identification.

Signed-off-by: Max Hsu <max.hsu@sifive.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
Add the SiFive FU740-C000 PLIC compatible string to the binding
documentation.

This follows the SiFive IP versioning scheme which requires SoC-specific
compatible strings for proper hardware identification, even when the IP
blocks are functionally identical.

Signed-off-by: Max Hsu <max.hsu@sifive.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
Add a distinct configuration for the SiFive FU740-C000 ethernet
controller to comply with the SiFive IP versioning guidelines.

The FU740 ethernet controller uses the same management IP block as
the FU540, which is tightly coupled with the Cadence MACB IP and
manages boundary signals. To avoid code duplication while maintaining
distinct SoC identification, this patch:

- Renames sifive_fu540_macb_mgmt to sifive_macb_mgmt to reflect
  that it's shared between FU540 and FU740
- Adds a fu740_c000_config structure that reuses the FU540
  initialization functions
- Follows the established pattern in this driver where multiple
  SoC configs share the same init functions

Signed-off-by: Max Hsu <max.hsu@sifive.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
Update the ethernet node compatible string from "sifive,fu540-c000-gem"
to "sifive,fu740-c000-gem" to comply with the SiFive IP versioning
scheme documented in sifive-blocks-ip-versioning.txt.

The versioning scheme requires SoC-specific compatible strings even when
IP blocks are functionally identical.

Signed-off-by: Max Hsu <max.hsu@sifive.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
Update the PLIC compatible string from "sifive,fu540-c000-plic" to
"sifive,fu740-c000-plic" to comply with the SiFive IP versioning
scheme documented in sifive-blocks-ip-versioning.txt.

The versioning scheme requires SoC-specific compatible strings for
proper hardware identification.

Signed-off-by: Max Hsu <max.hsu@sifive.com>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@linux-riscv-bot
Copy link
Author

Patch 1: "[1/5] dt-bindings: net: macb: Add SiFive FU740-C000 support"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 137.66 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[1/5] dt-bindings: net: macb: Add SiFive FU740-C000 support"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 998.71 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[1/5] dt-bindings: net: macb: Add SiFive FU740-C000 support"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1352.27 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[1/5] dt-bindings: net: macb: Add SiFive FU740-C000 support"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 26.62 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[1/5] dt-bindings: net: macb: Add SiFive FU740-C000 support"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 27.46 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[1/5] dt-bindings: net: macb: Add SiFive FU740-C000 support"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.72 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[1/5] dt-bindings: net: macb: Add SiFive FU740-C000 support"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 81.69 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[1/5] dt-bindings: net: macb: Add SiFive FU740-C000 support"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[1/5] dt-bindings: net: macb: Add SiFive FU740-C000 support"
kdoc
Desc: Detects for kdoc errors
Duration: 0.91 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[1/5] dt-bindings: net: macb: Add SiFive FU740-C000 support"
module-param
Desc: Detect module_param changes
Duration: 0.26 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[1/5] dt-bindings: net: macb: Add SiFive FU740-C000 support"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[1/5] dt-bindings: net: macb: Add SiFive FU740-C000 support"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.31 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[2/5] dt-bindings: interrupt-controller: Add SiFive FU740-C000 PLIC"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 137.98 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[2/5] dt-bindings: interrupt-controller: Add SiFive FU740-C000 PLIC"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1000.87 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[2/5] dt-bindings: interrupt-controller: Add SiFive FU740-C000 PLIC"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1353.39 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[2/5] dt-bindings: interrupt-controller: Add SiFive FU740-C000 PLIC"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 26.62 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[2/5] dt-bindings: interrupt-controller: Add SiFive FU740-C000 PLIC"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 27.89 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[2/5] dt-bindings: interrupt-controller: Add SiFive FU740-C000 PLIC"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.71 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[2/5] dt-bindings: interrupt-controller: Add SiFive FU740-C000 PLIC"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 82.68 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[2/5] dt-bindings: interrupt-controller: Add SiFive FU740-C000 PLIC"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[2/5] dt-bindings: interrupt-controller: Add SiFive FU740-C000 PLIC"
kdoc
Desc: Detects for kdoc errors
Duration: 0.89 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[2/5] dt-bindings: interrupt-controller: Add SiFive FU740-C000 PLIC"
module-param
Desc: Detect module_param changes
Duration: 0.26 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[2/5] dt-bindings: interrupt-controller: Add SiFive FU740-C000 PLIC"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[2/5] dt-bindings: interrupt-controller: Add SiFive FU740-C000 PLIC"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.31 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 3: "[3/5] net: macb: Add support for SiFive FU740-C000"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 137.34 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 3: "[3/5] net: macb: Add support for SiFive FU740-C000"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 81.94 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 3: "[3/5] net: macb: Add support for SiFive FU740-C000"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 3: "[3/5] net: macb: Add support for SiFive FU740-C000"
kdoc
Desc: Detects for kdoc errors
Duration: 0.91 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 3: "[3/5] net: macb: Add support for SiFive FU740-C000"
module-param
Desc: Detect module_param changes
Duration: 0.27 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 3: "[3/5] net: macb: Add support for SiFive FU740-C000"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 3: "[3/5] net: macb: Add support for SiFive FU740-C000"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.31 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 4: "[4/5] riscv: dts: sifive: fu740: Use correct ethernet compatible string"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 137.33 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 4: "[4/5] riscv: dts: sifive: fu740: Use correct ethernet compatible string"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1070.98 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 4: "[4/5] riscv: dts: sifive: fu740: Use correct ethernet compatible string"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1428.22 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 4: "[4/5] riscv: dts: sifive: fu740: Use correct ethernet compatible string"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 26.04 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 4: "[4/5] riscv: dts: sifive: fu740: Use correct ethernet compatible string"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 28.13 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 4: "[4/5] riscv: dts: sifive: fu740: Use correct ethernet compatible string"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.75 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 4: "[4/5] riscv: dts: sifive: fu740: Use correct ethernet compatible string"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 82.01 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 4: "[4/5] riscv: dts: sifive: fu740: Use correct ethernet compatible string"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 4: "[4/5] riscv: dts: sifive: fu740: Use correct ethernet compatible string"
kdoc
Desc: Detects for kdoc errors
Duration: 0.88 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 4: "[4/5] riscv: dts: sifive: fu740: Use correct ethernet compatible string"
module-param
Desc: Detect module_param changes
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 4: "[4/5] riscv: dts: sifive: fu740: Use correct ethernet compatible string"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.21 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 4: "[4/5] riscv: dts: sifive: fu740: Use correct ethernet compatible string"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.30 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 5: "[5/5] riscv: dts: sifive: fu740: Use correct PLIC compatible string"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 137.06 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 5: "[5/5] riscv: dts: sifive: fu740: Use correct PLIC compatible string"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1068.27 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 5: "[5/5] riscv: dts: sifive: fu740: Use correct PLIC compatible string"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1437.77 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 5: "[5/5] riscv: dts: sifive: fu740: Use correct PLIC compatible string"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 26.30 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 5: "[5/5] riscv: dts: sifive: fu740: Use correct PLIC compatible string"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 28.14 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 5: "[5/5] riscv: dts: sifive: fu740: Use correct PLIC compatible string"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 0.87 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 5: "[5/5] riscv: dts: sifive: fu740: Use correct PLIC compatible string"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 82.95 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 5: "[5/5] riscv: dts: sifive: fu740: Use correct PLIC compatible string"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.22 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 5: "[5/5] riscv: dts: sifive: fu740: Use correct PLIC compatible string"
kdoc
Desc: Detects for kdoc errors
Duration: 0.90 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 5: "[5/5] riscv: dts: sifive: fu740: Use correct PLIC compatible string"
module-param
Desc: Detect module_param changes
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 5: "[5/5] riscv: dts: sifive: fu740: Use correct PLIC compatible string"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.21 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 5: "[5/5] riscv: dts: sifive: fu740: Use correct PLIC compatible string"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.28 seconds
Result: PASS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants